Add textCapSentences flag to inputType attribute

Closes issue #112
pockethub · Jul 13, 2012 · b3c56b8 · b3c56b8
1 parent b7b7c41
commit b3c56b8
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 19 deletions.
diff --git a/app/res/layout/comment_create.xml b/app/res/layout/comment_create.xml
@@ -26,15 +26,13 @@
 
     <EditText
         android:id="@+id/et_comment"
-        style="@style/EditText"
+        style="@style/FormalMultiLineEditText"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:layout_alignParentLeft="true"
         android:layout_below="@id/v_header_separator"
         android:layout_margin="10dp"
-        android:gravity="top"
         android:hint="@string/comment_hint"
-        android:inputType="textMultiLine|textAutoCorrect"
         android:scrollbars="horizontal|vertical" >
 
         <requestFocus />

diff --git a/app/res/layout/gist_create.xml b/app/res/layout/gist_create.xml
@@ -59,12 +59,9 @@
 
                 <EditText
                     android:id="@+id/et_gist_description"
-                    style="@style/EditText"
+                    style="@style/FormalSingleLineEditText"
                     android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
-                    android:hint="@string/gist_description_hint"
-                    android:inputType="text|textAutoCorrect"
-                    android:singleLine="true" />
+                    android:hint="@string/gist_description_hint" />
 
                 <TextView
                     style="@style/HeaderTitleText"

diff --git a/app/res/layout/issue_edit.xml b/app/res/layout/issue_edit.xml
@@ -41,11 +41,8 @@
 
             <EditText
                 android:id="@+id/et_issue_title"
-                style="@style/EditText"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:inputType="text|textAutoCorrect"
-                android:singleLine="true" />
+                style="@style/FormalSingleLineEditText"
+                android:layout_width="match_parent" />
 
             <TextView
                 style="@style/HeaderTitleText"
@@ -125,11 +122,8 @@
 
             <EditText
                 android:id="@+id/et_issue_body"
-                style="@style/EditText"
+                style="@style/FormalMultiLineEditText"
                 android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:gravity="top"
-                android:inputType="textMultiLine|textAutoCorrect"
                 android:minLines="5"
                 android:scrollbars="horizontal|vertical" />
         </LinearLayout>

diff --git a/app/res/values/styles.xml b/app/res/values/styles.xml
@@ -14,7 +14,12 @@
   See the License for the specific language governing permissions and
   limitations under the License.
 -->
-<resources>
+<resources xmlns:android="http://schemas.android.com/apk/res/android">
+
+    <style name="Global">
+        <item name="android:layout_height">wrap_content</item>
+        <item name="android:layout_width">wrap_content</item>
+    </style>
 
     <style name="AvatarActionBar">
         <item name="android:layout_width">28dp</item>
@@ -47,14 +52,24 @@
         <item name="android:divider">@null</item>
     </style>
 
-    <style name="EditText">
+    <style name="EditText" parent="Global">
         <item name="android:textColor">@color/text</item>
         <item name="android:textCursorDrawable">@drawable/edit_text_cursor</item>
         <item name="android:textSize">14sp</item>
         <item name="android:padding">10dp</item>
         <item name="android:background">@drawable/edit_text_background</item>
     </style>
 
+    <style name="FormalMultiLineEditText" parent="EditText">
+        <item name="android:gravity">top</item>
+        <item name="android:inputType">textMultiLine|textAutoCorrect|textCapSentences</item>
+    </style>
+
+    <style name="FormalSingleLineEditText" parent="EditText">
+        <item name="android:singleLine">true</item>
+        <item name="android:inputType">text|textAutoCorrect|textCapSentences</item>
+    </style>
+
     <style name="LoginEditText" parent="EditText">
         <item name="android:layout_width">match_parent</item>
         <item name="android:layout_height">wrap_content</item>