Fix multiple universe output #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafichris
added a commit
to rafichris/ESPixelStick
that referenced
this pull request
Nov 13, 2016
|
edit: Responded to wrong PR |
|
I should have looked at open pull requests before but the changes in this pull request are equivalent to those in a99d1ff which is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With v2 update multiple universe output became practically unusable in my setup (multiple universes + offset from Jinx! software).
When Start Channel setting is > 1, random flickering renders instead of actual pixel data on universes after the first one. Start/end position calculations in pixels buffer were correct only for zero offset scenario, some math added to fix that.