Fixed missing ESP32 start uart isr caused by adding the timer support for ESP8266 #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the output image
Set max GPIO value to 34 for relay outputs
henrygab
reviewed
May 4, 2022
| @@ -85,7 +85,7 @@ extra_scripts = ${env.extra_scripts} | |||
| ;~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~; | |||
| [esp32git] | |||
| extends = esp32 | |||
| build_flags = ${esp32.build_flags} | |||
| build_flags = ${esp32.build_flags} -mtext-section-literals | |||
There was a problem hiding this comment.
For this commit, you wrote:
Added compiler option that does not include unused function / modules in the output image
However, the documentation page doesn't indicate this flag affects whether an unused function or module is in the final output image. Typically, I would expect Link-Time-Optimization (LTO) to remove unused functions and modules. Does the placement location of string literals impact LTO?
Can you help me understand the source that suggested this happens via the use of this parameter?
…ausing issues in newer versions of the IDF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.