Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for m5stack atom boards #541

Merged
merged 1 commit into from Jun 14, 2022
Merged

Add support for m5stack atom boards #541

merged 1 commit into from Jun 14, 2022

Conversation

bramoosterhuis
Copy link
Contributor

No description provided.

MartinMueller2003
MartinMueller2003 reviewed Jun 11, 2022
View reviewed changes
Copy link
Collaborator

@MartinMueller2003 MartinMueller2003 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. However, you will also need to add your board type to the github actions file found at:

ESPixelStick/.github/workflows/build.yaml

@bramoosterhuis bramoosterhuis force-pushed the dev/m5stack-atom-support branch 2 times, most recently from 475220b to d2888e2 Compare June 14, 2022 07:20
@bramoosterhuis
Copy link
Contributor Author

Done! I also missed adding the platform to [platformio]->default_envs in ESPixelStick/platformio.ini.

I hope it's all good now

@MartinMueller2003
Copy link
Collaborator

@forkineye - This looks good to me.

@forkineye forkineye merged commit 65607da into forkineye:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMueller2003 MartinMueller2003 MartinMueller2003 left review comments

@forkineye forkineye Awaiting requested review from forkineye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bramoosterhuis @MartinMueller2003 @forkineye