Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Olimex ESP32 Gateway #583

Merged
merged 15 commits into from Nov 30, 2022
Merged

Conversation

NickSchaf
Copy link
Contributor

Adds the support for running on the Olimex ESP32 GATEWAY

This board has on-board Ethernet, on-board SD card slot, and several GPIO through a header.

Tested with 5 output (1 UART + 4 RMT) all running at the same time.
Ethernet works.

SD card has been unsuccessful so far; the CS line is not connected on the board, but even with MOSI, MISO, and CLK setup, SD card init fails.

Copy link
Collaborator

@MartinMueller2003 MartinMueller2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to clean up the definitions file to bring it in line with the current format. Your flash tool changes are in the wrong project.



#define SUPPORT_RMT_OUTPUT
#define DEFAULT_RMT_0_GPIO gpio_num_t::GPIO_NUM_12 // Tested working
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have removed the use of RMT channel 0 due to a conflict with the UDP processing (Root cause unknown at this time). Also, You should use as many UART channels as possible (in this case two) because they have far lower ISR processing loads.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved GPIO12 to UART 2

//Output Manager
#define SUPPORT_UART_OUTPUT
#define DEFAULT_UART_1_GPIO gpio_num_t::GPIO_NUM_4 // Supposed to be SD Card, but R10 not populated
#define UART_LAST OutputChannelId_UART_1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label is no longer used

#define DEFAULT_RMT_3_GPIO gpio_num_t::GPIO_NUM_32 // Tested working
/*
Notes:
- Got exceptions and board resets when using either of GPIO_NUM_36 or GPIO_NUM_35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPIO 35 & 36 are input only. They cannot be used as outputs.

board rev G (resistors R10, R11, R9 are not populated on the board)
*/
// TODO: 39 is also available on the header, maybe also use 33 (LED output)
#define RMT_LAST OutputChannelId_RMT_4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer used


// #define SUPPORT_RELAY_OUTPUT

#if defined(SUPPORT_OutputType_WS2801) || defined(SUPPORT_OutputType_APA102)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic has been moved to the GPIO_Defs file

// TODO: 39 is also available on the header, maybe also use 33 (LED output)
#define RMT_LAST OutputChannelId_RMT_4

// #define SUPPORT_OutputType_WS2801 // requires a change in the html directory
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output type definitions have been moved to the end of the file. Please keep them consistent with the existing file layout. This makes future maintenance easier. I suggest taking a current version from another ethernet capable platform like the GPIO_Defs_ESP32_ESP3DEUXQuattro_DMX and adjusting it to your needs.

dist/firmware/firmware.json Outdated Show resolved Hide resolved
@NickSchaf
Copy link
Contributor Author

I've made the requested updates to ESPixelStick/src/platformDefinitions/GPIO_Defs_ESP32_Olimex_Gateway.hpp by reformatting using another newer device as a model.
Removed the changes to firmware.json and will put them in a PR to the ESPSFlashTool repository instead.

Copy link
Collaborator

@MartinMueller2003 MartinMueller2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@forkineye forkineye merged commit 6817ef5 into forkineye:main Nov 30, 2022
@forkineye
Copy link
Owner

Fixed the target line for github Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants