Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx verification failed #46

Open
cycleworm opened this issue Nov 17, 2017 · 7 comments
Open

Tx verification failed #46

cycleworm opened this issue Nov 17, 2017 · 7 comments

Comments

@cycleworm
Copy link

when i send transactions from any client to any other client i rapidly receive the "Tx verification failed" error message in the daemon log. but the coins are being transfered from one wallet to another.


pushTransaction: transaction hash already present in index
Nov 17 22:10:13 vps473512 forknoted[1250]: 2017-Nov-17 22:10:13.174682 DEBUG Failed to push transaction d6ed120dc6db08ce14da719473d1f2f12c483540300d2cac98b2b9f715322e25 to pool, already exists
Nov 17 22:10:13 vps473512 forknoted[1250]: 2017-Nov-17 22:10:13.174731 INFO [54.37.64.234:8498 OUT] Tx verification failed
Nov 17 22:10:13 vps473512 forknoted[1250]: 2017-Nov-17 22:10:13.252319 TRACE [46.125.249.91:11105 INC] NOTIFY_NEW_TRANSACTIONS
Nov 17 22:10:13 vps473512 forknoted[1250]: 2017-Nov-17 22:10:13.259533 DEBUG pushTransaction: transaction hash already present in index
Nov 17 22:10:13 vps473512 forknoted[1250]: 2017-Nov-17 22:10:13.259603 DEBUG Failed to push transaction d6ed120dc6db08ce14da719473d1f2f12c483540300d2cac98b2b9f715322e25 to pool, already exists
Nov 17 22:10:13 vps473512 forknoted[1250]: 2017-Nov-17 22:10:13.259661 INFO [46.125.249.91:11105 INC] Tx verification failed
Nov 17 22:10:13 vps473512 forknoted[1250]: 2017-Nov-17 22:10:13.790682 TRACE [178.113.248.32:64781 INC] NOTIFY_NEW_TRANSACTIONS


does anybody know why this occurs and how to solve?

i use version 2.1.2.1251 on every machine.

grafik

thanks

@cycleworm
Copy link
Author

cycleworm commented Nov 17, 2017 via email

@soldate
Copy link

soldate commented Nov 23, 2017

Im having the same problem..

@CherryDT
Copy link

CherryDT commented Dec 15, 2017

Same - Could it be that nodes send out messages regarding new transactions to other nodes including those from which they already received it? But this can always happen even if a direct response were avoided (i.e. A broadcasts to B, B to C, C to A - A already has it at that point), so it sounds like it should not be an error in that case.

Does it maybe have something to do with this?

//TODO: add announce usage here

...at the end of handle_notify_new_transactions

@ns1000
Copy link

ns1000 commented Apr 28, 2018

This is still a problem. Transactions are being communicated that already exist in the transaction pool. And to handle (ignore) those transactions takes too much cpu power.

@aerycrypto
Copy link

@ns1000

Transactions are being communicated that already exist in the transaction pool. And to handle (ignore) those transactions takes too much cpu power.

What do u mean by this? i do not understand. How to avoid this tx verification failed. any solution?

@ns1000
Copy link

ns1000 commented May 4, 2018

There is no solution without changing the source code. In the function handle_notify_new_transactions, executing m_core.addTransactionToPool takes a lot of time. I did a test by adding some code to skip this function after x number of failures in the sequence and it improved the daemon performance. It obviously is not a good way to solve it though.

@aerycrypto
Copy link

Any guide what you change in the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants