Another way to check if pass the test #66
Conversation
|
What the hell is this? Have you really included an entire virtualenv in the pull request? |
|
Oh, that's mean. I'm sorry about that, thank you for point out the mistake I have made, I will change it once I get home. But this PR is not a garbage. Have you make the changes, but when you use pytest, it shows 0 item collected in 0.01second? And that was happened last time I testing the project, since I was new to git, so I commit a lot of time, and I am sorry about that. But that's also the reason why I found out that using module install can also test if it's wrong with the changes I have made. |
|
And thank you mention that I have to delete the virtualenv file, I think I would like to put that on contributing document, it allows newbie like me understand how to make a change in a right way. |
|
I make the number of file correct and pull another request, I will close this PR, thanks for teaching again. |
|
@LuckyPigeon Please run @depau Please be polite and welcoming to new contributors. I understand this might become frustrating but we believe in Open Code of Conduct or see CODE_OF_CONDUCT. This will result in pragmatic and productive conversations. |
|
@PrabhanshuAttri Thanks for sharing some tutorial, it's very helpful. |
|
@LuckyPigeon and @depau you can join our slack channel as well. Try this: git tutorial game |
.travis.yml
Outdated
| @@ -28,4 +28,4 @@ deploy: | |||
| password: $PYPI_PASSWORD | |||
| on: | |||
| branch: master | |||
| condition: $SHOULD_DEPLOY = 1 | |||
| condition: $SHOULD_DEPLOY = 1 | |||
There was a problem hiding this comment.
Please undo this change. Here is travis guideline for on condition deploy.
CONTRIBUTING.md
Outdated
|
|
||
| 6. Commit your changes and push your branch to GitHub:: | ||
| ```shell | ||
| $ sudo pip install PyBeacon |
There was a problem hiding this comment.
This will install PyBeacon from PyPi, not from local repo after making changes. Remove this
| @@ -111,6 +112,7 @@ def encodeUid(uid): | |||
| ret = [] | |||
| for i in range(0, len(uid), 2): | |||
| ret.append(int(uid[i:i+2], 16)) | |||
| """Python's final character""" | |||
There was a problem hiding this comment.
Change this to Final byte stream character in Python
PyBeacon/PyBeacon.py
Outdated
| @@ -119,6 +121,7 @@ def uidIsValid(uid): | |||
| """UID Validation.""" | |||
| if len(uid) == 32: | |||
| try: | |||
| """Must not be alpha except ABCDEF""" | |||
There was a problem hiding this comment.
Change this to UID characters must belong to base 16
PyBeacon/PyBeacon.py
Outdated
| @@ -170,6 +173,7 @@ def decodeUrl(encodedUrl): | |||
| """ | |||
| decodedUrl = schemes[encodedUrl[0]] | |||
| for c in encodedUrl[1:]: | |||
| """Unprintable character""" | |||
There was a problem hiding this comment.
These are just not the unprintable chars. Please read about Eddystone URL and UID here and here. Remove this comment. Also, update your branch.
|
@PrabhanshuAttri When I saw the PR #67 , I have already push the update changes, is there any way to move this push to another branch? |
Sometimes I use py.test got failed, so I find out that I can use pip setup.py install, if install successfully and the outcome is the same as I imagine, then I can suggest that will pass the py.test.