Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong "main" JavaScript file name in package.json #313

Closed
wants to merge 1 commit into from
Closed

Fix wrong "main" JavaScript file name in package.json #313

wants to merge 1 commit into from

Conversation

phanect
Copy link

@phanect phanect commented Jan 12, 2017

main file is not ./lib/form_data but ./lib/form_data.js.
This makes error when you use form-data in TypeScript code. (See screenshot below)

Error on import

@coveralls
Copy link

coveralls commented Jan 12, 2017 •
edited

Coverage Status

Coverage remained the same at 97.927% when pulling fac5d4e on phanect:master into 03444d2 on form-data:master.

@phanect
Copy link
Author

phanect commented Jan 12, 2017

Sorry, this is my fault.
According to npm document, you don't need .js extension.
It is already reported as TypeScript's bug, and will be fixed.

@phanect phanect closed this Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phanect @coveralls