Fix rounding on iteration-distribution calculations #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrpeon-form3
changed the title
nvloff-f3
force-pushed
the
fix-iteration-distribution-rounding
branch
2 times, most recently
from
c1ca547
to
72dc431
Compare
When using very low rates intended to only fire the scenarios a couple times over the duration, the calculations for the iteration distribution could fail to add up to 1 by the last tick of the iteration. Using `Ceil` instead of `Round` ensures 1 is always reached consistently. See added test cases for examples that would fail to trigger the scenario without the fix. Co-authored-by: Kevin Intriago <kevin.intriago@form3.tech>
nvloff-f3
force-pushed
the
fix-iteration-distribution-rounding
branch
from
994e344
to
817300c
Compare
liam-shepherd-form3
approved these changes
Jun 11, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Co-authored-by: Kevin Intriago kevin.intriago@form3.tech
When using very low rates intended to only fire the scenario a couple times over the duration, the calculations for the iteration distribution could fail to add up to 1 by the last tick of the iteration, missing executions (or failing to trigger the scenario at all if only 1 run was intended).
Using
Ceilinstead ofRoundensures 1 is always reached consistently. See added test cases for examples that would fail to trigger the scenario without the fix.