feat: Add Create function for githubipallowlist_ip_allow_list_entry resource #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esource This change adds a `githubipallowlist_ip_allow_list_entry` resource with a limited implementation. It implements one of the functions managing `githubipallowlist_ip_allow_list_entry`, Create, on an organization level. The resource still lacks Read, Update and Delete functions, so it's not fully functional. Intention of this change is to provide a chunk of code that's manageable for a reviewer together that can actually be run with a real results (changes to the allow list). To validate changes run the `simple` example from `examples` directory: 1. Follow [Building The Provider section from README](https://github.com/form3tech-oss/terraform-provider-githubipallowlist/blob/5f6a0e2f6bafc5c041256b8fd4512eb8a0b7e936/README.md#building-the-provider) 2. Generate a Personal Access Token (classic) with an `admin:org` scope. 3. Run the following script filling missing variables: ```shell cd $PROJECT_ROOT/examples/simple export GITHUB_TOKEN=$GENERATED_TOKEN export GITHUB_ORGANIZATION=$YOUR_ORGANIZATION_NAME terraform plan terraform apply ``` 4. Manually delete IP `1.2.3.4/32` allow list entry from your organization.
pzmi-f3
force-pushed
the
pzmi-org-entry-create
branch
from
5f6a0e2
to
f98973d
Compare
pzmi-f3
force-pushed
the
pzmi-org-entry-create
branch
from
480acc1
to
8c7d729
Compare
bart-lisiecki-form3
previously approved these changes
Jan 2, 2023
bart-lisiecki-form3
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
githubipallowlist_ip_allow_list_entryresource with a limited implementation. It implements one of the functions managinggithubipallowlist_ip_allow_list_entry, Create, on an organization level. The resource still lacks Read, Update and Delete functions, so it's not fully functional. Intention of this change is to provide a chunk of code that's manageable for a reviewer together that can actually be run with a real results (changes to the allow list).To validate changes run the
simpleexample fromexamplesdirectory:admin:orgscope.1.2.3.4/32allow list entry from your organization.Example output of
terraform apply: