Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocaml 4.14 #217

Open
wants to merge 15 commits into
base: ocaml-4.13
Choose a base branch
from
Open

Ocaml 4.14 #217

wants to merge 15 commits into from

Conversation

clarus
Copy link
Collaborator

@clarus clarus commented Jun 22, 2022

No description provided.

@clarus clarus force-pushed the ocaml-4.14 branch 2 times, most recently from 82a7b6f to c7b7aed Compare June 24, 2022 08:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (4988eb3) 68.71% compared to head (8812f06) 68.52%.

Files Patch % Lines
src/pathName.ml 47.36% 20 Missing ⚠️
src/attribute.ml 12.50% 14 Missing ⚠️
src/ast.ml 0.00% 13 Missing ⚠️
src/monadEval.ml 0.00% 9 Missing ⚠️
src/type.ml 50.00% 8 Missing ⚠️
src/typeDefinition.ml 85.71% 3 Missing ⚠️
src/constant.ml 80.00% 2 Missing ⚠️
src/exp.ml 83.33% 2 Missing ⚠️
src/structure.ml 91.66% 2 Missing ⚠️
src/monad.ml 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           ocaml-4.13     #217      +/-   ##
==============================================
- Coverage       68.71%   68.52%   -0.19%     
==============================================
  Files              32       32              
  Lines            4737     4788      +51     
==============================================
+ Hits             3255     3281      +26     
- Misses           1482     1507      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alizter
Copy link

Alizter commented Dec 29, 2022

@clarus Hi, will you be able to make progress with this? I would like to try testing coq-of-ocaml in Dune.

@clarus
Copy link
Collaborator Author

clarus commented Dec 29, 2022

@Alizter Hi, sorry I forgot about that, I am working on it this week.

@clarus
Copy link
Collaborator Author

clarus commented Jan 4, 2023

@Alizter I made a pull-request on the opam repository to add a release of coq-of-ocaml compatible with OCaml 4.14: ocaml/opam-repository#22839

@clarus
Copy link
Collaborator Author

clarus commented Jan 6, 2023

@Alizter the version of coq-of-ocaml compatible with OCaml 4.14 is now published: ocaml/opam-repository#22839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants