fix(payments): fix metadata ever growing (#1422)

formancehq · Apr 16, 2024 · 7ede2f8 · 7ede2f8
1 parent 26605e6
commit 7ede2f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/components/payments/cmd/api/internal/storage/metadata.go b/components/payments/cmd/api/internal/storage/metadata.go
@@ -28,7 +28,8 @@ func (s *Storage) UpdatePaymentMetadata(ctx context.Context, paymentID models.Pa
 		Model(&metadataToInsert).
 		On("CONFLICT (payment_id, key) DO UPDATE").
 		Set("value = EXCLUDED.value").
-		Set("changelog = metadata.changelog || EXCLUDED.changelog").
+		Set("changelog = payment_metadata.changelog || EXCLUDED.changelog").
+		Where("payment_metadata.value != EXCLUDED.value").
 		Exec(ctx)
 	if err != nil {
 		return e("failed to update payment metadata", err)

diff --git a/components/payments/cmd/connectors/internal/storage/payments.go b/components/payments/cmd/connectors/internal/storage/payments.go
@@ -126,6 +126,7 @@ func (s *Storage) UpsertPaymentsMetadata(ctx context.Context, metadata []*models
 		On("CONFLICT (payment_id, key) DO UPDATE").
 		Set("value = EXCLUDED.value").
 		Set("changelog = payment_metadata.changelog || EXCLUDED.changelog").
+		Where("payment_metadata.value != EXCLUDED.value").
 		Exec(ctx)
 	if err != nil {
 		return e("failed to create metadata", err)