Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move api cursor to bunpaginate package #1343

Merged
merged 1 commit into from Mar 19, 2024
Merged

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Mar 19, 2024

Summary by CodeRabbit

  • Refactor
    • Implemented a new pagination system across various components using bunpaginate.Cursor to enhance data listing and retrieval processes.
  • New Features
    • Enhanced pagination capabilities in accounts, balances, bank accounts, payments, pools, transfer initiations, tasks, triggers, workflows, policies, reconciliations, and transaction listings for improved user experience and system performance.
  • Tests
    • Updated tests across multiple modules to accommodate the new pagination system, ensuring reliability and stability.

@gfyrag gfyrag requested a review from a team as a code owner March 19, 2024 09:34
Copy link
Contributor

coderabbitai bot commented Mar 19, 2024

Warning

Rate Limit Exceeded

@gfyrag has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 59 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between ede425c and 2aaf8bd.

Walkthrough

The overarching change involves transitioning from a custom pagination cursor (api.Cursor) to a standardized pagination implementation (bunpaginate.Cursor) across various components of a payment system. This update affects the handling of lists in APIs, services, storage, and tests, ensuring a more unified approach to pagination throughout the system.

Changes

Files Change Summary
.../internal/api/... (multiple files) Replaced api.Cursor with bunpaginate.Cursor in function signatures, response structs, and imports.
.../internal/storage/... (multiple files) Updated function signatures to return bunpaginate.Cursor for listing entities. Changed import paths to support bunpaginate.
.../cmd/connectors/internal/... (multiple files) Transitioned from api.Cursor to bunpaginate.Cursor in APIs and storage for task listing.
ee/.../internal/api/... (multiple files across orchestration, reconciliation, search, and wallets components) Updated to use bunpaginate.Cursor for pagination, including changes in imports and function signatures.
libs/go-libs/api/... (multiple files) Removed custom Cursor logic in favor of using bunpaginate.Cursor, affecting base response and utility functions.
libs/go-libs/bun/bunpaginate/... (new files) Introduced new files defining the bunpaginate.Cursor structure and related pagination logic.

"In the land of code and wire,
where the data streams never tire,
a rabbit hopped with eager glee,
for pagination set free.
🐇💻
From api.Cursor's tight embrace,
to bunpaginate's open space,
a leap, a bound, a joyous chase!"

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@gfyrag gfyrag added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 4f5734d Mar 19, 2024
8 checks passed
@gfyrag gfyrag deleted the chore/move-cursor branch March 19, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants