PHP7 & Symfony3 compatibility #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created branch https://github.com/formapro/JsFormValidatorBundle/tree/1.3 from 1.2 if it must be done from master let me know. |
This was referenced Mar 29, 2016
|
That was fast, thanks, PR sent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Symfony 3
I'm sorry this PR is so big but... :)
I have also created 1.3 branch which supports Symfony 2.7 and 2.8 but I cannot send a PR since this branch does not exist here. @66Ton99 Could you create it so I can send a PR?
The branch is here https://github.com/vaniocz/JsFormValidatorBundle/tree/1.3
There are probably some edge cases with the BC "layer" but since I fixed the build and all tests pass I think we can solve them in a future.