Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed order of arguments in implode function #158

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fixed order of arguments in implode function #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Model/JsModelAbstract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static function phpValueToJs($value)
$jsObject[] = "'$paramName':" . self::phpValueToJs($paramValue);
}

return sprintf('{%1$s}', implode($jsObject, ','));
return sprintf('{%1$s}', implode(',', $jsObject));
}
// For a sequential array
elseif (is_array($value)) {
Expand All @@ -63,7 +63,7 @@ public static function phpValueToJs($value)
$jsArray[] = self::phpValueToJs($item);
}

return sprintf('[%1$s]', implode($jsArray, ','));
return sprintf('[%1$s]', implode(',', $jsArray));
}
// For string
elseif (is_string($value)) {
Expand Down Expand Up @@ -101,4 +101,4 @@ public function toArray()

return $result;
}
}
}