Skip to content
This repository has been archived by the owner on Jun 8, 2019. It is now read-only.

Move 'printICUMessage(ast)' into separate project #19

Closed
rightaway opened this issue Nov 15, 2015 · 2 comments
Closed

Move 'printICUMessage(ast)' into separate project #19

rightaway opened this issue Nov 15, 2015 · 2 comments

Comments

@rightaway
Copy link

The printICUMessage(ast) function which was suggested to me in formatjs/intl-messageformat#118 works great and is very useful as a standalone tool to convert an ICU AST into an ICU string pattern. Would you consider moving this into its own separate project so that I could depend on it directly in my package.json? Would be better so that I don't have to copy-paste the code and keep it in sync as updates are made upstream. Could be called for example something like icuAstToPattern.

@rightaway
Copy link
Author

Would you accept a pull request for this? I'm happy to take it on.

@ericf
Copy link
Collaborator

ericf commented Apr 3, 2016

Moving it to a separate repo seems like overkill to me.

What I'd like to do is move this code into the react-intl repo and setup that Git repo to support multiple npm packages. That way all the related code is in one place and CI is setup once. You're free to take this code and do what you wish in accordance to the license.

I'm going to close this issue, since I don't want to manage more Git repos.

@ericf ericf closed this as completed Apr 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants