fix(@formatjs/cli): Change default hashing to a longer & stronger hash

to prevent collision
formatjs · Jun 4, 2020 · 0bb8358 · 0bb8358
1 parent 4d09912
commit 0bb8358
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/packages/cli/src/cli.ts b/packages/cli/src/cli.ts
@@ -137,7 +137,7 @@ async function main(argv: string[]) {
       await extract(processedFiles, {
         outFile: cmdObj.outFile,
         idInterpolationPattern:
-          cmdObj.idInterpolationPattern || '[contenthash:5]',
+          cmdObj.idInterpolationPattern || '[sha1:contenthash:base64:6]',
         messagesDir: cmdObj.messagesDir,
         extractSourceLocation: cmdObj.extractSourceLocation,
         moduleSourceName: cmdObj.moduleSourceName,

diff --git a/packages/cli/tests/extract/integration_tests/__snapshots__/index.test.ts.snap b/packages/cli/tests/extract/integration_tests/__snapshots__/index.test.ts.snap
@@ -34,7 +34,7 @@ Array [
   Object {
     "defaultMessage": "No ID",
     "description": "no ID",
-    "id": "e695b",
+    "id": "fAT9Q5",
   },
 ]
 `;
@@ -75,7 +75,7 @@ Array [
   Object {
     "defaultMessage": "No ID",
     "description": "no ID",
-    "id": "e695b",
+    "id": "fAT9Q5",
   },
 ]
 `;
@@ -166,7 +166,7 @@ Array [
       "line": 37,
     },
     "file": "defineMessages/actual.js",
-    "id": "e695b",
+    "id": "fAT9Q5",
     "start": Object {
       "column": 19,
       "line": 34,
@@ -205,7 +205,7 @@ Array [
   Object {
     "defaultMessage": "No ID",
     "description": "no ID",
-    "id": "e695b",
+    "id": "fAT9Q5",
   },
 ]
 `;
@@ -274,7 +274,7 @@ Array [
   Object {
     "defaultMessage": "No ID",
     "description": "no ID",
-    "id": "e695b",
+    "id": "fAT9Q5",
   },
   Object {
     "defaultMessage": "formatted message",
@@ -318,7 +318,7 @@ Array [
   Object {
     "defaultMessage": "No ID",
     "description": "no ID",
-    "id": "e695b",
+    "id": "fAT9Q5",
   },
 ]
 `;
@@ -353,7 +353,7 @@ Array [
   Object {
     "defaultMessage": "No ID",
     "description": "no ID",
-    "id": "e695b",
+    "id": "fAT9Q5",
   },
   Object {
     "defaultMessage": "formatted message",