fix(react-intl): fix children type of FormattedMessage, fix #3117

formatjs · Aug 16, 2021 · 567a131 · 567a131 · SRachamim · Aug 22, 2021
1 parent bf0f7a0
commit 567a131
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/packages/react-intl/src/components/message.tsx b/packages/react-intl/src/components/message.tsx
@@ -16,7 +16,7 @@ export interface Props<
 > extends MessageDescriptor {
   values?: V
   tagName?: React.ElementType<any>
-  children?(...nodes: React.ReactNodeArray): React.ReactElement | null
+  children?(nodes: React.ReactNodeArray): React.ReactElement | null
   ignoreTag?: IntlMessageFormatOptions['ignoreTag']
 }
 
@@ -47,12 +47,8 @@ function FormattedMessage(props: Props) {
     ignoreTag,
   })
 
-  if (!Array.isArray(nodes)) {
-    nodes = [nodes]
-  }
-
   if (typeof children === 'function') {
-    return children(nodes)
+    return children(Array.isArray(nodes) ? nodes : [nodes])
   }
 
   if (Component) {

diff --git a/packages/react-intl/tests/unit/testUtils.tsx b/packages/react-intl/tests/unit/testUtils.tsx
@@ -6,7 +6,7 @@ export function mountFormattedComponentWithProvider<P>(
   Comp: React.ComponentType<P>
 ) {
   return (
-    props: P & {children?(...nodes: React.ReactNodeArray): React.ReactNode},
+    props: P & {children?(nodes: React.ReactNodeArray): React.ReactNode},
     providerProps: IntlConfig = {locale: 'en'}
   ) => {
     const result = render(
@@ -22,7 +22,7 @@ export function mountFormattedComponentWithProvider<P>(
     const {rerender} = result
     const rerenderProps = (
       newProps: P & {
-        children?(...nodes: React.ReactNodeArray): React.ReactNode
+        children?(nodes: React.ReactNodeArray): React.ReactNode
       } = props,
       newProviderProps: IntlConfig = providerProps
     ) =>