feat(@formatjs/intl-getcanonicallocales): expose shouldPolyfill to de…

…tect if platform needs our polyfill
formatjs · Aug 18, 2020 · ba0aac6 · ba0aac6
1 parent 8820290
commit ba0aac6
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/packages/intl-getcanonicallocales/BUILD b/packages/intl-getcanonicallocales/BUILD
@@ -27,10 +27,10 @@ alias(
     actual = "%s.pack" % PACKAGE_NAME,
 )
 
-SRCS = glob(["src/**/*.ts"]) + [
-    "index.ts",
-    "polyfill.ts",
-]
+SRCS = glob([
+    "src/**/*.ts",
+    "*.ts",
+])
 
 TESTS = glob([
     "tests/*.test.ts",

diff --git a/packages/intl-getcanonicallocales/polyfill.ts b/packages/intl-getcanonicallocales/polyfill.ts
@@ -1,4 +1,5 @@
-import {getCanonicalLocales} from './';
+import {getCanonicalLocales} from '.';
+import {shouldPolyfill} from './should-polyfill';
 if (typeof Intl === 'undefined') {
   if (typeof window !== 'undefined') {
     Object.defineProperty(window, 'Intl', {
@@ -10,14 +11,7 @@ if (typeof Intl === 'undefined') {
     });
   }
 }
-if (
-  !('getCanonicalLocales' in Intl) ||
-  // Native Intl.getCanonicalLocales is just buggy
-  // https://bugs.chromium.org/p/v8/issues/detail?id=10682
-  ((Intl as any).getCanonicalLocales as typeof getCanonicalLocales)(
-    'und-x-private'
-  )[0] === 'x-private'
-) {
+if (shouldPolyfill()) {
   Object.defineProperty(Intl, 'getCanonicalLocales', {
     value: getCanonicalLocales,
     writable: true,

diff --git a/packages/intl-getcanonicallocales/should-polyfill.ts b/packages/intl-getcanonicallocales/should-polyfill.ts
@@ -0,0 +1,10 @@
+export function shouldPolyfill() {
+  return (
+    typeof Intl === 'undefined' ||
+    !('getCanonicalLocales' in Intl) ||
+    // Native Intl.getCanonicalLocales is just buggy
+    // https://bugs.chromium.org/p/v8/issues/detail?id=10682
+    ((Intl as any).getCanonicalLocales as any)('und-x-private')[0] ===
+      'x-private'
+  );
+}