test: add safari to the Sauce Labs

formatjs · Jan 22, 2021 · da83412 · da83412
1 parent a5ab023
commit da83412
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/BUILD b/BUILD
@@ -196,7 +196,7 @@ karma_test(
         "start",
         "$(rootpath //:karma.conf.js)",
         "--browsers",
-        "sl_edge,sl_chrome,sl_firefox,sl_ie_11",
+        "sl_edge,sl_chrome,sl_firefox,sl_ie_11,sl_safari",
     ] + ["$$(rlocation $(locations %s))" % f for f in KARMA_TESTS],
 )
 

diff --git a/karma.conf.js b/karma.conf.js
@@ -6,10 +6,11 @@ module.exports = function (config) {
   // Check out https://saucelabs.com/platforms for all browser/OS combos
   const customLaunchers = {
     // Sauce Labs keeps failing to get a safari instance
-    // sl_safari: {
-    //   base: 'SauceLabs',
-    //   browserName: 'safari',
-    // },
+    sl_safari: {
+      base: 'SauceLabs',
+      browserName: 'safari',
+      version: '12',
+    },
     sl_edge: {
       base: 'SauceLabs',
       browserName: 'MicrosoftEdge',