feat(intl-messageformat): format scale stem in number skeleton correc…

…tly, fix #2414
formatjs · Dec 17, 2020 · e48b60c · e48b60c
1 parent 3419140
commit e48b60c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/intl-messageformat/src/formatters.ts b/packages/intl-messageformat/src/formatters.ts
@@ -11,6 +11,7 @@ import {
   isTimeElement,
   MessageFormatElement,
   isTagElement,
+  ExtendedNumberFormatOptions,
 } from 'intl-messageformat-parser';
 import {
   MissingValueError,
@@ -194,10 +195,16 @@ export function formatToParts<T>(
           : isNumberSkeleton(el.style)
           ? el.style.parsedOptions
           : undefined;
+
+      if (style && (style as ExtendedNumberFormatOptions).scale) {
+        value =
+          (value as number) *
+          ((style as ExtendedNumberFormatOptions).scale || 1);
+      }
       result.push({
         type: PART_TYPE.literal,
         value: formatters
-          .getNumberFormat(locales, style)
+          .getNumberFormat(locales, style as Intl.NumberFormatOptions)
           .format(value as number),
       });
       continue;

diff --git a/packages/intl-messageformat/tests/index.test.ts b/packages/intl-messageformat/tests/index.test.ts
@@ -847,6 +847,15 @@ describe('IntlMessageFormat', function () {
     ).toBe('£123,456.79');
   });
 
+  it('number skeleton with scale', function () {
+    expect(
+      new IntlMessageFormat(
+        '{amount, number, ::percent scale/0.01}',
+        'en-US'
+      ).format({amount: 12.3})
+    ).toBe('12%');
+  });
+
   it('date skeleton', function () {
     expect(
       new IntlMessageFormat('{d, date, ::yyyyMMMdd}', 'en-US').format({