fix(@formatjs/intl): fix __addMessages issues with references

formatjs · Feb 9, 2021 · f9266f9 · f9266f9
1 parent e8790d4
commit f9266f9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/packages/intl/src/create-intl.ts b/packages/intl/src/create-intl.ts
@@ -173,11 +173,9 @@ export function createIntl<T = string>(
         );
       }
 
-      // @ts-expect-error this is fine
-      resolvedConfig.messages = {
-        ...resolvedConfig.messages,
-        ...messages,
-      };
+      Object.keys(messages).forEach(k => {
+        resolvedConfig.messages[k] = messages[k];
+      });
     },
   };
 }
diff --git a/packages/intl/tests/create-intl.test.ts b/packages/intl/tests/create-intl.test.ts
@@ -13,3 +13,13 @@ test('createIntl', function () {
     })
   ).toBe('bar');
 });
+
+test('__addMessages', function () {
+  const intl = createIntl({
+    locale: 'en',
+    messages: {},
+  });
+  expect(intl.messages).toEqual({});
+  intl.__addMessages({foo: ''});
+  expect(intl.messages).toEqual({foo: ''});
+});