Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing UMD bundle for multiple packages #2013

Closed
JakeChampion opened this issue Aug 21, 2020 · 2 comments
Closed

Missing UMD bundle for multiple packages #2013

JakeChampion opened this issue Aug 21, 2020 · 2 comments
Labels

Comments

@JakeChampion
Copy link
Contributor

Which package?
@formatjs/intl-datetimeformat
@formatjs/intl-displaynames
@formatjs/intl-getcanonicallocales
@formatjs/intl-listformat
@formatjs/intl-numberformat
@formatjs/intl-pluralrules
@formatjs/intl-relativetimeformat

Describe the bug
Up to version 2.0.2 @formatjs/intl-datetimeformat had a UMD bundle at location dist/umd/polyfill.js and it was removed in version 2.1.0 and I don't think has been re-added since then.

Up to version 3.0.2 @formatjs/intl-displaynames had a UMD bundle at location dist/umd/polyfill.js and it was removed in version 3.1.0 and I don't think has been re-added since then.

Up to version 1.2.10 @formatjs/intl-getcanonicallocales had a UMD bundle at location dist/umd/polyfill.js and it was removed in version 1.3.0 and I don't think has been re-added since then.

Up to version 3.0.2 @formatjs/intl-listformat had a UMD bundle at location dist/umd/polyfill.js and it was removed in version 3.1.0 and I don't think has been re-added since then.

Up to version 5.0.2 @formatjs/intl-numberformat had a UMD bundle at location dist/umd/polyfill.js and it was removed in version 5.1.0 and I don't think has been re-added since then.

Up to version 3.0.2 @formatjs/intl-pluralrules had a UMD bundle at location dist/umd/polyfill.js and it was removed in version 3.1.0 and I don't think has been re-added since then.

Up to version 6.0.2 @formatjs/intl-relativetimeformat had a UMD bundle at location dist/umd/polyfill.js and it was removed in version 6.1.0 and I don't think has been re-added since then.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://unpkg.com/browse/@formatjs/intl-datetimeformat@2.0.2/
  2. You should see a dist folder
  3. Go to https://unpkg.com/browse/@formatjs/intl-datetimeformat@2.1.0/
  4. You should no longer see a dist folder
  5. Repeat steps 1 to 4 for the other packages and versions listed above.

Expected behavior
I would have expected the UMD bundle to still exist in the packages in minor releases such as these.

Additional context
It is also how polyfill-library (https://polyfill.io) can use these package since polybill-library does not use require or import at all.

@longlho
Copy link
Member

longlho commented Aug 21, 2020

Thanks for reporting. I didn't know polyfill-library needs UMD actually so will add them back. Tests did pass on the initial PR though so should I submit an issue for that on your side?

@JakeChampion
Copy link
Contributor Author

Yes please 👍

JakeChampion added a commit to JakeChampion/polyfill-library that referenced this issue Aug 21, 2020
…e missing the umd bundles

issue for the missing umd bundles -- formatjs/formatjs#2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants