Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to IntlShape and IntlConfig #2821

Closed
glen-84 opened this issue Apr 12, 2021 · 4 comments
Closed

Improvements to IntlShape and IntlConfig #2821

glen-84 opened this issue Apr 12, 2021 · 4 comments

Comments

@glen-84
Copy link
Contributor

glen-84 commented Apr 12, 2021

#2804 (reply in thread)

  1. Set the generic type argument of IntlShape to string by default, like IntlConfig.
  2. Mark config fields like formats, defaultFormats, and onError as optional in the IntlConfig type.
longlho added a commit that referenced this issue Apr 13, 2021
@longlho
Revert "fix(@formatjs/intl): make some attrs (formats, defaultFormats…
d9ebada 
…, onError) optional, fix #2821"

This reverts commit 7989222.
longlho added a commit that referenced this issue Apr 13, 2021
@longlho
fix(@formatjs/intl): make IntlShape generic default to string, fix #2821
08d48f2
@longlho
Copy link
Member

longlho commented Apr 13, 2021

For (2) you can use OptionalIntlConfig

@glen-84
Copy link
Contributor Author

glen-84 commented Apr 13, 2021

@longlho OptionalIntlConfig is not exported from vue-intl.

@longlho
Copy link
Member

longlho commented Apr 15, 2021

yeah I think OptionalIntlConfig should have been IntlConfig and IntlConfig should have been ResolvedIntlConfig basically :-/ will try to find time to fix this

@longlho
Copy link
Member

longlho commented Apr 19, 2021

fixed in latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longlho @glen-84