Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React v16 #1023

Merged
merged 1 commit into from
Sep 3, 2017
Merged

Support React v16 #1023

merged 1 commit into from
Sep 3, 2017

Conversation

ykzts
Copy link
Contributor

@ykzts ykzts commented Sep 2, 2017 

...
warning "react-intl@2.3.0" has incorrect peer dependency "react@^0.14.9 || ^15.0.0".
...

@okuryu
Copy link
Member

okuryu commented Sep 2, 2017

I'm not familiar with React 16, but it seems to have several breaking changes. We don't need to care for them?
facebook/react#10294

@ykzts
Copy link
Contributor Author

ykzts commented Sep 2, 2017

There are lots of internal changes in React v16. However, there are few changes to the public API. Backwards compatibility is maintained.

I have been using React Int16 for a while with React v16, but there was no problem.

okuryu
okuryu approved these changes Sep 3, 2017
View reviewed changes
Copy link
Member

@okuryu okuryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's try this. 😄

@okuryu okuryu merged commit 4edf4fe into formatjs:master Sep 3, 2017
@ykzts ykzts deleted the react-v16 branch September 3, 2017 05:58
@okuryu okuryu mentioned this pull request Sep 5, 2017
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okuryu okuryu okuryu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ykzts @okuryu