Allow introspection access to the component wrapped by InjectIntl #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for universal apps, to be able to access statics set in the actual rendering component. (This mirrors what react-redux's Connect already does.)
ericf
added a commit
that referenced
this pull request
Nov 24, 2015
Allow introspection access to the component wrapped by InjectIntl
|
@ericf just to add context, allowing inspecting into the wrapped component allows unit testing with shallow rendering. But in that use case, hoisting is not necessary, and being able to access WrappedComponent like in this PR is sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access to the wrapped components (when not mounted) is useful for universal apps; for instance @erikras' universal example depends on being able to find certain static functions.
This PR also fixes an incidental typo in
injectIntland a couple mis-copypasted tests.