Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@formatjs/icu-messageformat-parser): preprocess 'j' date time skeleton before parsing as suggested in the Unicode guide #3544

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

batjaa
Copy link
Contributor

@batjaa batjaa commented Apr 17, 2022

  • Preprocess 'j' date time skeleton before parsing as suggested in the Unicode guide
  • Add unit tests & tests for intl-messageformat for date time skeleton 'j' patterns

@batjaa batjaa force-pushed the add-j branch 2 times, most recently from 2ae836e to 0437693 Compare April 25, 2022 04:44
@batjaa batjaa marked this pull request as ready for review April 25, 2022 04:45
@batjaa
Copy link
Contributor Author

batjaa commented Apr 26, 2022

@longlho would you approve the tests/builds?

@batjaa
Copy link
Contributor Author

batjaa commented Apr 27, 2022

Fixed broken build:

  • IDE automatically formatted some part of snapshot file
  • Run prettier to fix styling issues

@longlho if you can approve for builds again. Do I need to request building everytime I make a change?

@longlho
Copy link
Member

longlho commented Apr 27, 2022

Unfortunately yeah because it's your first PR

@batjaa
Copy link
Contributor Author

batjaa commented Apr 27, 2022

Got it. All good, just wanted to confirm.

  • Fix unit tests :duh:

@longlho longlho changed the title Preprocess date skeleton pattern feat(@formatjs/icu-messageformat-parser): preprocess 'j' date time skeleton before parsing as suggested in the Unicode guide Apr 27, 2022
@longlho longlho merged commit 7173e29 into formatjs:main Apr 27, 2022
@longlho
Copy link
Member

longlho commented Apr 27, 2022

Thanks a lot for your contributions!

@batjaa
Copy link
Contributor Author

batjaa commented Apr 27, 2022

👍 I'll try to contribute more as time allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants