Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved hasNativeStartsWith check #4130

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Improved hasNativeStartsWith check #4130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/icu-messageformat-parser/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ function createLocation(start: Position, end: Position): Location {

// #region Ponyfills
// Consolidate these variables up top for easier toggling during debugging
const hasNativeStartsWith = !!String.prototype.startsWith
const hasNativeStartsWith =
!!String.prototype.startsWith && '_a'.startsWith('a', 1)
const hasNativeFromCodePoint = !!String.fromCodePoint
const hasNativeFromEntries = !!(Object as any).fromEntries
const hasNativeCodePointAt = !!String.prototype.codePointAt
Expand Down