Add Jest snapshot testing example #683
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
|
Docs is ready and I'll add it after the pull request is merged. |
| <AppMain/> | ||
| <AppFooter/> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
Can you make sure the files end with a newline so that Git can track future changes better.
| <FormattedMessage {...messages.copyright} /> | ||
| </div> | ||
| </footer> | ||
| ); |
| import { FormattedMessage, defineMessages } from 'react-intl'; | ||
|
|
||
| const messages = defineMessages({ | ||
| copyright: { |
There was a problem hiding this comment.
There's a mix of 2 and 4 space indentation. If you don't mind can you make it consistent throughout the example?
| const { counter } = this.state; | ||
|
|
||
| return ( | ||
| <main className="app-main" onClick={this.onClick}> |
| } | ||
| } | ||
|
|
||
| export default AppMain; |
| let tree = component.toJSON(); | ||
|
|
||
| expect(tree).toMatchSnapshot(); | ||
| }); |
| let tree = component.toJSON(); | ||
|
|
||
| expect(tree).toMatchSnapshot(); | ||
| }); |
| tree = component.toJSON(); | ||
|
|
||
| expect(tree).toMatchSnapshot(); | ||
| }); |
| ReactDOM.render( | ||
| <RootContainer/>, | ||
| document.getElementById('root') | ||
| ); |
| ); | ||
| }; | ||
|
|
||
| export default createComponentWithIntl; |
|
@ericf sorry for mistakes. I'm resolve it and send pull request with updated eslint for check this mistakes. |
|
@zouxuoz no worries about the mistakes. I appreciate that you took the time to update the eslint config 😄 Thanks so much for creating this example app and writing up the docs on Jest testing. This will end up serving as my guide when I eventually get around to rewriting React Intl's own tests using Jest. |
I'm added example to show how use Jest snapshot testing for applications with React Intl. (resolve #681)