Make all examples build on windows #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, but it doesn't stop scripts running. Added .cmd extents to allow examples.js to run on windows. Made the hello world example actually use a non-standard locale so that you can see that something is happening.
Added missing semi-colon (sorry - my local build and tests didn't complain!)
Clarified formatting in examples.js
…cripts allows the scripts in all the examples to run Now no known problems on windows.
|
Now the example are failing with |
|
Looking at package.json, I can see cross-env (^3.1.3) is listed as a devDependency. Are you sure you did an npm install before attempting to rebuild? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all examples build on windows by using cross-env before all explicitly path-referenced node commands