New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeZone prop to IntlProvider #893
Conversation
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
68c3121
to
69db1fe
Compare
+1 For this ! |
69db1fe
to
0d277d1
Compare
Hi @ericf! This PR is quite critical to ensure our app's progress - have you had any chance to take a look at it? 🙏 Thank you very much! Cheers! |
Bump :) |
+1 |
@@ -0,0 +1,24 @@ | |||
import React, {Component, PropTypes} from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should import PropTypes
from prop-type
in React 15.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing! I've updated the example app to use React 15.5.
+1 |
@ericf is there any update on merging this PR ? |
This would be super convenient to have ... Preferrably sooner rather than later. 😸 |
Could you resolve the conflicts for this? |
29f2647
to
986d589
Compare
@okuryu updated! |
986d589
to
bd73ea9
Compare
+1. any update? |
+1 very minor q on package dependencies: are you able to uplift to latest react/react-scripts (16.2,1.0.17)? |
It's been a long time. Any update about this? |
Any plans to merge this? |
Hi! all checks have passed, would anyone merge this PR? :) |
+1. Is there a timeframe for when this capability will become available? |
Hi all, I have volunteered to maintain this project and this specific PR seems to be really important for a lot of folks. I am working on reviewing this PR, let's get this merged as soon as possible without further delay @jeremyyap, thanks for all the work put in |
Resolve #702
This adds a timeZone prop to IntlProvider which will be used as the default timeZone for formatDate and formatTime.
My team would like to see #707 merged but there has been no activity for two months. Here are the same commits with the requested changes.