Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeZone prop to IntlProvider #893

Merged
merged 9 commits into from Sep 10, 2018

Conversation

jeremyyap
Copy link
Contributor

Resolve #702

This adds a timeZone prop to IntlProvider which will be used as the default timeZone for formatDate and formatTime.

My team would like to see #707 merged but there has been no activity for two months. Here are the same commits with the requested changes.

@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@allenwq
Copy link

allenwq commented Mar 12, 2017

+1 For this !

@jeremyyap
Copy link
Contributor Author

Hi @ericf! This PR is quite critical to ensure our app's progress - have you had any chance to take a look at it? 🙏

Thank you very much! Cheers!

@mv-stripe
Copy link

Bump :)

@potty
Copy link

potty commented May 9, 2017

+1

@@ -0,0 +1,24 @@
import React, {Component, PropTypes} from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should import PropTypes from prop-type in React 15.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! I've updated the example app to use React 15.5.

@MikkoIdean
Copy link

+1

@Calvein
Copy link

Calvein commented Jul 31, 2017

@ericf is there any update on merging this PR ?

@neutraali
Copy link

This would be super convenient to have ... Preferrably sooner rather than later. 😸

@okuryu
Copy link
Member

okuryu commented Sep 15, 2017

Could you resolve the conflicts for this?

@jeremyyap jeremyyap force-pushed the timezone-prop branch 2 times, most recently from 29f2647 to 986d589 Compare September 15, 2017 16:42
@jeremyyap
Copy link
Contributor Author

@okuryu updated!

@samlecuyer
Copy link

samlecuyer commented Nov 2, 2017

@ericf or @okuryu any chance you'd merge this?

@couds
Copy link

couds commented Dec 24, 2017

+1. any update?

@papasmile
Copy link
Contributor

+1

very minor q on package dependencies: are you able to uplift to latest react/react-scripts (16.2,1.0.17)?

@gameunite
Copy link

It's been a long time. Any update about this?

@eMarek
Copy link

eMarek commented Jun 8, 2018

Any plans to merge this?

@alexhoma
Copy link

alexhoma commented Jun 8, 2018

Hi! all checks have passed, would anyone merge this PR? :)

@dteirney
Copy link

dteirney commented Aug 3, 2018

+1. Is there a timeframe for when this capability will become available?

@sourabh2k15
Copy link
Contributor

Hi all, I have volunteered to maintain this project and this specific PR seems to be really important for a lot of folks. I am working on reviewing this PR, let's get this merged as soon as possible without further delay

@jeremyyap, thanks for all the work put in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet