-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow object for description prop #990
Conversation
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
license is signed. |
+1 for trying to match up API with doc, very nice. AFAICT, it would be safe to use A couple suggestions that might make Maintainers happy with your PR:
[1] https://github.com/yahoo/babel-plugin-react-intl/blob/ed5dd0004d3a9368d335bd08c11c0b2cff832e1d/src/index.js#L208 |
+1 for getting this merged, makes testing harder with the added noise this causes. Would appreciate this being merged! |
@papasmile Thanks for your suggestions.
Sure. PR for
I think a space after comma in an array is a common practice in JavaScript. We also already run linting by ESLint, but lint rules change is welcome if we need a little work. And this change looks good to me. Let's merge in this month if no concern by others. |
Fixing prop definitions to match https://github.com/yahoo/react-intl/wiki/Components#message-descriptor