This repository has been archived by the owner on May 18, 2019. It is now read-only.
Use better CLDR data sources #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This a **major**, **breaking** change that revamps how this package extracts the CLDR data. In order to get better and more up-to-date CLDR data, this package now uses: `formatjs-extract-cldr-data` which uses `make-plural`. The data is now from CLDR v26.
|
CLA is valid! |
This was referenced Mar 2, 2015
|
I've tested this locally with an updated |
| locales : undefined, | ||
| pluralRules : false, | ||
| relativeFields: false, | ||
| prelude : '', |
There was a problem hiding this comment.
I've been doing this lately on purpose to avoid refactoring hazards. Since this is possible in ES5+ and that this package only runs in node, I figured it would be good to start using it. In fact trailing commas in function call expressions is on deck for ES7: https://github.com/tc39/ecma262
|
Seems it needs to update the README. |
|
@okuryu Yeah, I'll update the README for this PR, so it can be merged then published. |
|
🎱 |
|
This is in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a major, breaking change that revamps how this package extracts the CLDR data.
I'm currently finishing up testing these changes downstream, so this should not be merged until noted.In order to get better and more up-to-date CLDR data, this package now uses:
formatjs-extract-cldr-datawhich usesmake-plural. The data is now from CLDR v26.These changes supersede PR #1.