This repository has been archived by the owner on May 23, 2019. It is now read-only.
Nest default formats and properly merge specified formats #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| formats = extend(objCreate(MessageFormat.FORMATS), formats); | ||
| // Creates a new object with the specified `formats` merged with the | ||
| // default formats. | ||
| formats = this._mergeFormats(MessageFormat.FORMATS, formats); |
There was a problem hiding this comment.
I still think this is an expensive operation, closing the default formats, plus the custom one! so I will like to see hotwiring when possible.
There was a problem hiding this comment.
It's actually faster now than it was before because of the check I do to only merge if there's formats for a type on formats object passed in.
|
+1 |
|
@caridy This is actually slightly faster than it was before ;) |
|
This looks good to me. I can't believe how clean this looks and how the formats will be called make so much sense. Tests appear to be failing due to credentials on sauce. +1 |
|
The tests always fail because of sauce. @drewfish what do we have to do to make them pass in PRs and on master? Currently they fail in both places. |
ericf
added a commit
that referenced
this pull request
Feb 11, 2014
Nest default formats and properly merge specified formats
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nests the default formats, and will properly merge the custom
formatsprovided via the constructor.