Merge changes 'refactor modules dependencies' from TCS #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacks0N23
force-pushed
the
build_deps_from_tcs
branch
from
9e7917f
to
e848c89
Compare
Jacks0N23
force-pushed
the
build_deps_from_tcs
branch
from
e848c89
to
b2fa4e9
Compare
added 2 commits
April 14, 2023 18:03
Jacks0N23
force-pushed
the
build_deps_from_tcs
branch
from
f8d1f83
to
f4d823f
Compare
stepango
requested changes
Apr 17, 2023
build-settings/conventions/src/main/kotlin/convention-plugins.settings.gradle.kts
Outdated
Show resolved
Hide resolved
|
|
||
| } | ||
| repositories { | ||
| google() |
There was a problem hiding this comment.
we don't need google and gradle portal repositories for most of the plugins
There was a problem hiding this comment.
somehow, due to magic of settings plugins, we need these ones in application settings.gradle.kts
stepango
reviewed
Apr 19, 2023
application/build.gradle.kts
Outdated
| ) | ||
| ) | ||
| } | ||
|
|
||
|
|
||
| tasks.register("build") { |
There was a problem hiding this comment.
lets add some comments since its not obvious why we need this tasks
There was a problem hiding this comment.
do we need this tasks?
it is a lifecycle task. it's just to be able to call root project task in this way: ./gradlew :build which is the synonym ./gradlew build
- Remove root project tasks, cause they are not needed - Remove empty plugins block in convention-plugins.settings.gradle.kts - Remove doubling rootProject.name - Move includeBuild build-dependencies out of pluginManagement block - Add includeBuild plugins cause we apply tools.forma.android and tools.forma.deps as settings plugin
stepango
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source here tinkoff-mobile-tech#1