New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate character list feature from databinding module to viewBinding #121

Merged

stepango merged 1 commit into master from migration_characters_list

May 8, 2023

Collaborator

michaem commented May 3, 2023

Rename :application:feature:characters:list:databinding module to :application::feature:characters:list:viewbinding where use viewBinding module instead of databinding
Move files from ../databinding folder to ../viewbinding
Migrate code from databinding to observing viewModel in CharactersListFragment
Migrate code in list items from databinding to simple binding and setting click listeners


          Migrate character list feature from databinding module to viewBinding

a92f0e8

michaem requested review from stepango and grine4ka

May 3, 2023 21:57

grine4ka approved these changes

View reviewed changes

stepango approved these changes

View reviewed changes

stepango merged commit 61d1058 into master

4 checks passed

stepango deleted the migration_characters_list branch

May 8, 2023 13:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment