Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the ICharacterItem.kt to an api target. #55

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

samokryl
Copy link
Collaborator

@samokryl samokryl commented Dec 7, 2020

resolve #47

@samokryl samokryl self-assigned this Dec 7, 2020
Copy link
Collaborator

@ntnsmirnov ntnsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary empty.kt file in the root directory of the module :list.api

@michaem
Copy link
Collaborator

michaem commented Dec 7, 2020

unnecessary empty.kt file in the root directory of the module :list.api

empty.kt is necessary for :api modules types, cause for kotlin-only compile requirements. In that case, need to have one kt file at least.

You can create issue for do some enhancement in that behaviour of :api modules and other kotlin-only.

@stepango stepango dismissed ntnsmirnov’s stale review December 7, 2020 18:06

empty.kt file could be resolved later 👍

@stepango
Copy link
Collaborator

stepango commented Dec 7, 2020

@samokryl @ntnsmirnov Happy to see you here, guys! Thanks for helping us with this awesome project.

@stepango stepango merged commit f9b403d into master Dec 7, 2020
@stepango stepango deleted the characters_list_api branch December 7, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move feature models from :databinding target to :api target
4 participants