feat: Added Dynamic Link Previews

[anjy7]

What does this PR do?

Adds Dynamic Link Previews

Fixes #1064

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change adds a new database migration
• This change requires a documentation update

How should this be tested?

• Share survey link

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

@anjy7 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[jobenjada]

@anjy7 can you add a screenshot or recording for reference? :)

[anjy7]

@anjy7 can you add a screenshot or recording for reference? :)

Yeah its a work in progress, will add soon. Working on the the image..

[anjy7]

Hey @jobenjada, its ready, please have a look. The brand color and the survey name is dynamic..

[jobenjada]

hey hey! I tried two different ways to test this and it doesnt work:

And Im getting this error:

Is next/head still the right approach for app dir? 🤔

Could you maybe create a Loom for me to better understand how you are testing this ?

Additionally, please resolve the merge conflict :)

[anjy7]

hey hey! I tried two different ways to test this and it doesnt work:

And Im getting this error:

Is next/head still the right approach for app dir? 🤔

Could you maybe create a Loom for me to better understand how you are testing this ?

Additionally, please resolve the merge conflict :)

sure, I'll look into this and get back to you @jobenjada

[jobenjada]

@anjy7 perfect :) I know it'll be Monday morning, but can you maybe have a look tomorrow? :D Would love to include this in our Week 2 Review which I'll record tomorrow afternoon (would be evening in India)

[anjy7]

Hey @jobenjada, trying to debug it at present. And sure I’ll try to do it before evening :)

[anjy7]

Hey @jobenjada , I have made the changes, please have a look :)
Here's the loom recording as well - https://www.loom.com/share/35345359f50d4e219f804bb47a4d20c8?sid=dd014683-c1da-48b5-893e-15d490faac54

[mattinannt]

please remove the empty line

[mattinannt]

@anjy7 thanks a lot for the PR, looks great! From the technical side I would like to see a few more things changed before we merge the changes.

[anjy7]

Hey @mattinannt, I have made the changes. Also the share button wasn't working on the survey as ig someone had put a check whether the survey is single use or not ( this prevented the share dropdown opening if the survey is not single use ). I have removed it, please check it once :)

[mattinannt]

@anjy7 thanks a lot for the changes and also fixing the bug on the way :-) 💪 I will merge the PR now :-)

[mattinannt]

@anjy7 Unfortunately there is still a build error in the PR:

@formbricks/web:build: app/api/v1/og/route.tsx
@formbricks/web:build: Type error: Route "app/api/v1/og/route.tsx" does not match the required types of a Next.js Route.
@formbricks/web:build:   Invalid configuration "fetchCache":
@formbricks/web:build:     Expected ""auto" | "force-cache" | "force-no-store" | "only-no-store" | "default-no-store" | "default-cache" | "only-cache" | undefined", got "false".

Can you please solve this? :-) Then we are ready to merge! :-)

[anjy7]

Hey @mattinannt, I’ll look into this in a bit

[anjy7]

Hi @mattinannt, I built it locally and all the test cases passed..
this was the error message in the above failed merge - ../../packages/lib/storage/service.ts:70:26 Type error: Property 'getType' does not exist on type 'typeof import("/home/runner/work/formbricks/formbricks/node_modules/@types/mime/index")'.
Although it shouldnt be there as the build is successful locally, could you please maybe try merging it again?

[anjy7]

should work now @mattinannt