Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds hidden field functionality to surveys #1144

Merged
merged 13 commits into from
Oct 15, 2023
Merged

feat: adds hidden field functionality to surveys #1144

merged 13 commits into from
Oct 15, 2023

Conversation

rtpa25
Copy link
Contributor

@rtpa25 rtpa25 commented Oct 14, 2023 •
edited

What does this PR do?

Fixes (#887)

https://www.loom.com/share/5b5ecc20a80241c3aedb1c3f3d8bac69

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

Checklist

Required

  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2023

@rtpa25 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2023 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

@rtpa25 rtpa25 marked this pull request as draft October 14, 2023 10:17
@jobenjada
Copy link
Member

Tweaked the UI but struggle to push it:

image image

Also, if someone copies a value incl. a space, it can be submitted:
image

Looking forward to the final PR :)

@rtpa25
Copy link
Contributor Author

rtpa25 commented Oct 14, 2023 via email

rtpa25
rtpa25 commented Oct 15, 2023
View reviewed changes
Copy link
Contributor Author

@rtpa25 rtpa25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...b/app/(app)/environments/[environmentId]/surveys/[surveyId]/edit/components/SurveyEditor.tsx Outdated Show resolved Hide resolved
packages/database/.env Outdated Show resolved Hide resolved
@rtpa25 rtpa25 changed the title feat: adds hidden field inside every form and works on basic crud feat: adds hidden field functionality to surveys Oct 15, 2023
@rtpa25 rtpa25 marked this pull request as ready for review October 15, 2023 04:31
@rtpa25
Copy link
Contributor Author

rtpa25 commented Oct 15, 2023

@jobenjada @mattinannt awaiting review

@mattinannt
Copy link
Member

@rtpa25 Thanks a lot for the feature :-) 💪 Looks great!
We now have mix a different terms in Code and UI. Can you please rename the code variables and files that it's named Hidden Field instead of Hidden Question to be consistent?

@rtpa25
Copy link
Contributor Author

rtpa25 commented Oct 15, 2023

Done ☑️

@jobenjada jobenjada self-assigned this Oct 15, 2023
@jobenjada jobenjada added hacktoberfest complete these issues to gather points for Hacktoberfest hacktoberfest-accepted formtribe-2023 Issues related to Formtribe 2023 hackathon labels Oct 15, 2023
@mattinannt mattinannt added this pull request to the merge queue Oct 15, 2023
Merged via the queue into formbricks:main with commit a71ad7c Oct 15, 2023
6 of 8 checks passed
piyushgarg-dev pushed a commit to piyushgarg-dev/formbricks that referenced this pull request Oct 16, 2023
@rtpa25 @jobenjada
@mattinannt @piyushgarg-dev
feat: adds hidden field functionality to surveys (formbricks#1144)
bf32cef 
Co-authored-by: Johannes <72809645+jobenjada@users.noreply.github.com>
Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees

@jobenjada jobenjada

Labels
formtribe-2023 Issues related to Formtribe 2023 hackathon hacktoberfest complete these issues to gather points for Hacktoberfest hacktoberfest-accepted ❗️ migrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rtpa25 @jobenjada @mattinannt