Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github action that reports stripe usage #1599

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Fixes GitHub Action to use env vars as set (taking inspiration from the weekly summary cron job)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Nov 8, 2023 1:40pm
formbricks-com ⬜️ Ignored (Inspect) Nov 8, 2023 1:40pm

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

apps/web/app/api/cron/report-usage/route.ts

While the change from GET to POST is a good move for security reasons, it's also important to validate the input data in the POST request to prevent any potential security vulnerabilities.
Create Issue

    export async function POST(request: NextRequest): Promise<NextResponse> {
      const headersList = headers();
      const apiKey = headersList.get("x-api-key");
      const body = request.body;

      // Validate the body here

      if (!apiKey || apiKey !== CRON_SECRET) {
        return responses.notAuthenticatedResponse();
      }

      try {
        const teamsWithPaidPlan = await getTeamsWithPaidPlan();
        await Promise.all(teamsWithPaidPlan.map(reportTeamUsage));

        return responses.successResponse({}, true);
      } catch (error) {
        console.error(error);
        return responses.internalServerErrorResponse("Unable to handle the request: " + error.message, true);
      }
    }

It's a good practice to log the error message when an exception is thrown. This will help in debugging the issue when something goes wrong.
Create Issue

    try {
      const teamsWithPaidPlan = await getTeamsWithPaidPlan();
      await Promise.all(teamsWithPaidPlan.map(reportTeamUsage));

      return responses.successResponse({}, true);
    } catch (error) {
      console.error("Error while reporting team usage: ", error);
      return responses.internalServerErrorResponse("Unable to handle the request: " + error.message, true);
    }

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mattinannt mattinannt added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 7acd2cc Nov 9, 2023
14 checks passed
@mattinannt mattinannt deleted the shubham/stripe-report-usage-fix-action branch November 9, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants