Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opt billing page forcefully out of static generation #1600

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Sentry reported a few runtime errors when people visited the /billing-confirmation page because it used the searchParams for the page, it could not be rendered the SSG way hence causing error. This PR now forces it to use the SSR method hence hopefully not throwing any such error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Nov 8, 2023 2:11pm
formbricks-com ⬜️ Ignored (Inspect) Nov 8, 2023 2:11pm

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍💪

@mattinannt mattinannt added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit a2df7ab Nov 9, 2023
14 checks passed
@mattinannt mattinannt deleted the shubham/sentry-make-billing-page-opt-out-of-ssg branch November 9, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants