fix: infinite loop in onboarding

[mattinannt]

What does this PR do?

fix: infinite loop in onboarding

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change adds a new database migration
• This change requires a documentation update

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Nov 10, 2023 10:56am
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Nov 10, 2023 10:56am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

apps/web/app/(app)/onboarding/components/Objective.tsx

Instead of using the find method to get the selected objective or role, you can use a JavaScript object to map the labels to their corresponding ids. This will improve the performance from O(n) to O(1) and make the code more readable.
Create Issue

    const objectives = {
      "Increase conversion": "increase_conversion",
      "Improve user retention": "improve_user_retention",
      "Increase user adoption": "increase_user_adoption",
      "Sharpen marketing messaging": "sharpen_marketing_messaging",
      "Support sales": "support_sales",
      "Other": "other",
    };

    const handleNextClick = async () => {
      if (selectedChoice) {
        const selectedObjectiveId = objectives[selectedChoice];
        if (selectedObjectiveId) {
          // ...
        }
      }
    };

apps/web/app/(app)/onboarding/components/Role.tsx

Similar to the previous suggestion, you can use a JavaScript object to map the labels to their corresponding ids for roles. This will improve the performance from O(n) to O(1) and make the code more readable.
Create Issue

    const roles = {
      "Project Manager": "project_manager",
      "Engineer": "engineer",
      "Founder": "founder",
      "Marketing Specialist": "marketing_specialist",
      "Other": "other",
    };

    const handleNextClick = async () => {
      if (selectedChoice) {
        const selectedRoleId = roles[selectedChoice];
        if (selectedRoleId) {
          // ...
        }
      }
    };