Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add flix logo, remove dark mode #1774

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: add flix logo, remove dark mode #1774

merged 1 commit into from
Dec 12, 2023

Conversation

jobenjada
Copy link
Member

add flix logo, remove dark mode

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Dec 12, 2023 11:03pm
formbricks-com ⬜️ Ignored (Inspect) Dec 12, 2023 11:03pm

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada jobenjada changed the title add flix logo, remove dark mode fix: add flix logo, remove dark mode Dec 12, 2023
Copy link
Contributor

apps/formbricks-com/components/home/Hero.tsx

Consider using the loading="lazy" attribute for the Image components to improve the performance of the website. This will ensure that the images are only loaded when they are in the viewport, reducing the initial load time of the page.
Create Issue
See the diff
Checkout the fix

    <Image
      src={FlixbusLogo}
      alt="Flixbus Flix Flixtrain Logo"
      className="rounded-lg pb-1 hover:opacity-100 md:opacity-50"
      width={200}
      loading="lazy"
    />
git fetch origin && git checkout -b ReviewBot/Impro-yak62zp origin/ReviewBot/Impro-yak62zp

Consider using a map function to render the Image components. This will make the code more readable and maintainable. You can create an array of objects, where each object contains the properties of an image. Then, you can use the map function to render each image.
Create Issue
See the diff
Checkout the fix

    const images = [
      { src: FlixbusLogo, alt: "Flixbus Flix Flixtrain Logo", className: "rounded-lg pb-1 hover:opacity-100 md:opacity-50", width: 200 },
      // other images...
    ];

    images.map(image => (
      <Image
        src={image.src}
        alt={image.alt}
        className={image.className}
        width={image.width}
        loading="lazy"
      />
    ));
git fetch origin && git checkout -b ReviewBot/Impro-l1xzcyz origin/ReviewBot/Impro-l1xzcyz

apps/formbricks-com/components/shared/Header.tsx

Consider removing the unused import ThemeSelector from the Header.tsx file. This will reduce the size of the JavaScript bundle and improve the performance of the website.
Create Issue
See the diff
Checkout the fix

    // Remove this line
    // import { ThemeSelector } from "./ThemeSelector";
git fetch origin && git checkout -b ReviewBot/Impro-bsgp3c7 origin/ReviewBot/Impro-bsgp3c7

@jobenjada jobenjada added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit 7c3c665 Dec 12, 2023
14 of 15 checks passed
@jobenjada jobenjada deleted the lp/add-flixbus-logo branch December 12, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant