Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test for display services #1832

Merged
merged 5 commits into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/lib/display/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const selectDisplay = {
surveyId: true,
responseId: true,
personId: true,
status: true,
};

export const getDisplay = async (displayId: string): Promise<TDisplay | null> => {
Expand All @@ -42,7 +43,7 @@ export const getDisplay = async (displayId: string): Promise<TDisplay | null> =>
validateInputs([displayId, ZId]);

try {
const display = await prisma.response.findUnique({
const display = await prisma.display.findUnique({
where: {
id: displayId,
},
Expand Down Expand Up @@ -143,7 +144,6 @@ export const updateDisplayLegacy = async (
data,
select: selectDisplay,
});

displayCache.revalidate({
id: display.id,
surveyId: display.surveyId,
Expand All @@ -164,7 +164,6 @@ export const createDisplay = async (displayInput: TDisplayCreateInput): Promise<
validateInputs([displayInput, ZDisplayCreateInput]);

const { environmentId, userId, surveyId } = displayInput;

try {
let person;
if (userId) {
Expand All @@ -191,13 +190,11 @@ export const createDisplay = async (displayInput: TDisplayCreateInput): Promise<
},
select: selectDisplay,
});

displayCache.revalidate({
id: display.id,
personId: display.personId,
surveyId: display.surveyId,
});

return display;
} catch (error) {
if (error instanceof Prisma.PrismaClientKnownRequestError) {
Expand Down Expand Up @@ -337,7 +334,6 @@ export const deleteDisplayByResponseId = async (
personId: display.personId,
surveyId,
});

return display;
} catch (error) {
if (error instanceof Prisma.PrismaClientKnownRequestError) {
Expand Down
76 changes: 76 additions & 0 deletions packages/lib/display/tests/__mocks__/data.mock.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
import {
TDisplay,
TDisplayCreateInput,
TDisplayLegacyCreateInput,
TDisplayLegacyUpdateInput,
TDisplayUpdateInput,
} from "@formbricks/types/displays";

export const mockEnvironmentId = "clqkr5961000108jyfnjmbjhi";
export const mockSingleUseId = "qj57j3opsw8b5sxgea20fgcq";
export const mockSurveyId = "clqkr8dlv000308jybb08evgr";
export const mockUserId = "qwywazmugeezyfr3zcg9jk8a";
export const mockDisplayId = "clqkr5smu000208jy50v6g5k4";
export const mockId = "ars2tjk8hsi8oqk1uac00mo8";
export const mockPersonId = "clqnj99r9000008lebgf8734j";
export const mockResponseId = "clqnfg59i000208i426pb4wcv";

function createMockDisplay(overrides = {}) {
return {
id: mockDisplayId,
createdAt: new Date(),
updatedAt: new Date(),
surveyId: mockSurveyId,
responseId: null,
personId: null,
status: null,
...overrides,
};
}

export const mockDisplay: TDisplay = createMockDisplay();

export const mockDisplayWithPersonId: TDisplay = createMockDisplay({ personId: mockPersonId });

export const mockDisplayWithResponseId: TDisplay = createMockDisplay({
personId: mockPersonId,
responseId: mockResponseId,
});

export const mockDisplayInput: TDisplayCreateInput = {
environmentId: mockEnvironmentId,
surveyId: mockSurveyId,
};
export const mockDisplayInputWithUserId: TDisplayCreateInput = {
...mockDisplayInput,
userId: mockUserId,
};
export const mockDisplayInputWithResponseId: TDisplayCreateInput = {
...mockDisplayInputWithUserId,
responseId: mockResponseId,
};

export const mockDisplayLegacyInput: TDisplayLegacyCreateInput = {
responseId: mockResponseId,
surveyId: mockSurveyId,
};
export const mockDisplayLegacyInputWithPersonId: TDisplayLegacyCreateInput = {
...mockDisplayLegacyInput,
personId: mockPersonId,
};

export const mockDisplayUpdate: TDisplayUpdateInput = {
environmentId: mockEnvironmentId,
userId: mockUserId,
responseId: mockResponseId,
};

export const mockDisplayLegacyUpdateInput: TDisplayLegacyUpdateInput = {
personId: mockPersonId,
responseId: mockResponseId,
};

export const mockDisplayLegacyWithRespondedStatus: TDisplay = {
...mockDisplayWithPersonId,
status: "responded",
};
Loading
Loading