Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: object fit for logo on welcome card #1835

Merged
merged 2 commits into from
Dec 28, 2023
Merged

fix: object fit for logo on welcome card #1835

merged 2 commits into from
Dec 28, 2023

Conversation

jobenjada
Copy link
Member

What does this PR do?

Logos looked pretty bad on the welcome cards.

Fixes # (issue)

Introduced object fit prop so it can be changed to contain if needed:

image

vs

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

Checklist

@vercel Vercel
Copy link

vercel bot commented Dec 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 6:35am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 6:35am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 28, 2023 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

pandeymangg
pandeymangg approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@pandeymangg pandeymangg added this pull request to the merge queue Dec 28, 2023
Merged via the queue into main with commit 8a4ceae Dec 28, 2023
12 checks passed
@pandeymangg pandeymangg deleted the fix/logo-object-fit branch December 28, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandeymangg pandeymangg pandeymangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jobenjada @pandeymangg