Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak above the fold wording #1839

Merged
merged 6 commits into from
Dec 29, 2023
Merged

fix: tweak above the fold wording #1839

merged 6 commits into from
Dec 29, 2023

Conversation

jobenjada
Copy link
Member

image

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Dec 29, 2023 0:47am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Dec 29, 2023 0:47am

Copy link
Contributor

github-actions bot commented Dec 29, 2023

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

apps/formbricks-com/components/shared/Header.tsx

Listening to the scroll event can be expensive in terms of performance, especially if the event handler performs complex operations. In this case, the event handler is simple, but it's still a good practice to throttle or debounce the event to reduce the number of times the handler is called.
Create Issue
See the diff
Checkout the fix

    useEffect(() => {
      const handleScroll = throttle(() => {
        if (window.scrollY > 250) {
          setStickyNav(true);
        } else {
          setStickyNav(false);
        }
      }, 200);
      window.addEventListener("scroll", handleScroll);
      return () => {
        window.removeEventListener("scroll", handleScroll);
      };
    }, []);
git fetch origin && git checkout -b ReviewBot/Impro-yuh6ni4 origin/ReviewBot/Impro-yuh6ni4

It's a good practice to provide a skip link at the beginning of the page. This allows keyboard users to skip directly to the main content, bypassing the header navigation.
Create Issue
See the diff
Checkout the fix

    return (
      <>
        <a href="#maincontent" className="sr-only focus:not-sr-only">
          Skip to main content
        </a>
        <Popover className={`${stickyNavClass}`} as="header">
          ...
        </Popover>
      </>
    );
git fetch origin && git checkout -b ReviewBot/Impro-et7bta9 origin/ReviewBot/Impro-et7bta9

@jobenjada jobenjada added this pull request to the merge queue Dec 29, 2023
Merged via the queue into main with commit ae530d7 Dec 29, 2023
12 checks passed
@jobenjada jobenjada deleted the lp/tweak-wording branch December 29, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant