Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload Verify email page #1851

Merged
merged 3 commits into from
Jan 3, 2024
Merged

fix: reload Verify email page #1851

merged 3 commits into from
Jan 3, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented Jan 3, 2024

What does this PR do?

Fixes 1620

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  1. Create a new account without using any provider
  2. You now arrive on verify email page
  3. Open verification mail and click on confirm mail
  4. Check the previously opened tab

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) Visit Preview Jan 3, 2024 2:15pm
formbricks-com 猬滐笍 Ignored (Inspect) Visit Preview Jan 3, 2024 2:15pm

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Thank you for following the naming conventions for pull request titles! 馃檹

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks, looks great! :-)
I only added a new line between the two functions for readability and also extended the useEffect to remove the event listener on unmount.

@mattinannt mattinannt added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 0d74921 Jan 3, 2024
12 checks passed
@mattinannt mattinannt deleted the verify-email-page branch January 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants