feat: increase rate limit for client api endpoints

[ShubhamPalriwala]

What does this PR do?

Increases the client side API (including response submissions) rate limits to 100 per 5 mins! 🤞🏼

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Jan 16, 2024 11:03am
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Jan 16, 2024 11:03am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/lib/constants.ts

Instead of using magic numbers for time intervals, it would be more readable to define constants for these values. This will make the code easier to understand and maintain.
Create Issue
See the diff
Checkout the fix

    const ONE_MINUTE = 60 * 1000;
    const FIVE_MINUTES = 5 * ONE_MINUTE;
    const FIFTEEN_MINUTES = 15 * ONE_MINUTE;
    const ONE_HOUR = 60 * ONE_MINUTE;

    export const LOGIN_RATE_LIMIT = {
      interval: FIFTEEN_MINUTES,
      allowedPerInterval: 30,
    };

    export const CLIENT_SIDE_API_RATE_LIMIT = {
      interval: FIVE_MINUTES,
      allowedPerInterval: 100,
    };

    export const SHARE_RATE_LIMIT = {
      interval: ONE_HOUR,
      allowedPerInterval: 30,
    };

git fetch origin && git checkout -b ReviewBot/Impro-aysults origin/ReviewBot/Impro-aysults

[mattinannt]

@ShubhamPalriwala looks great, thanks for the fix 😊

[connorwinston]

Is there anyway to override these constants with environment variables?

[mattinannt]

@connorwinston Why do you want to overwrite them? what problem are you facing?

[connorwinston]

@mattinannt I would like to increase the number of requests that can be made specifically for shares and the other limits in general, they are pretty low. Additionally, the way I have this hosted/internally protected on our intranet means that some routes receive the same ip regardless of the user, which kind of breaks this. It would be nice to either configure the rate limiter amounts via ENV or disable/enable the ratelimit in general via ENV.