Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "How to add people" to People View #1910

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

hpk0304
Copy link
Contributor

@hpk0304 hpk0304 commented Jan 16, 2024

PR for add new feature

Add new button on People Page where users can link to external docs to read more about procedure how to add people in the view screen

Fixes: (issue)

image

Copy link

vercel bot commented Jan 16, 2024

@hpk0304 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the enhancement New feature or request label Jan 16, 2024
Copy link
Contributor

github-actions bot commented Jan 16, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

apps/web/app/(app)/environments/[environmentId]/people/page.tsx

Consider adding a tooltip to the "HowToAddPeopleButton" to provide more context about what the button does when hovered over. This can improve the user experience by providing immediate information about the button's functionality.
Create Issue
See the diff
Checkout the fix

    import { Tooltip } from "@formbricks/ui/Tooltip";

    <Tooltip content="Learn how to add people to your environment">
      <HowToAddPeopleButton />
    </Tooltip>
git fetch origin && git checkout -b ReviewBot/The-n-78cnxt8 origin/ReviewBot/The-n-78cnxt8

Comment on lines +1 to 3
import HowToAddPeopleButton from "@/app/(app)/environments/[environmentId]/components/HowToAddPeopleButton";
import Link from "next/link";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a tooltip to the 'HowToAddPeopleButton' to provide more context about what the button does when hovered over. This improves the user experience by providing immediate information about the button's functionality.

Suggested change
import HowToAddPeopleButton from "@/app/(app)/environments/[environmentId]/components/HowToAddPeopleButton";
import Link from "next/link";
import { Tooltip } from "@formbricks/ui/Tooltip";
<Tooltip content="Learn how to add people to your environment">
<HowToAddPeopleButton />
</Tooltip>

@mattinannt mattinannt changed the title [FOR-1703] [FEATURE] [Reserved] Add "How to add people" to People View feat: Add "How to add people" to People View Jan 17, 2024
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpk0304 Thanks a lot for this contribution 😊 Looks and works great! 💪

@mattinannt mattinannt added this pull request to the merge queue Jan 17, 2024
Merged via the queue into formbricks:main with commit 602238f Jan 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FOR-1703] [FEATURE] [Reserved] Add "How to add people" to People View
2 participants