Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Embed in an Email preview #1913

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: Embed in an Email preview #1913

merged 2 commits into from
Jan 17, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes 1725

Before:

Screenshot 2024-01-17 at 2 39 33鈥疨M Screenshot 2024-01-17 at 2 40 10鈥疨M

After:

Screenshot 2024-01-17 at 2 39 27鈥疨M Screenshot 2024-01-17 at 2 39 04鈥疨M

How should this be tested?

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) Visit Preview Jan 17, 2024 11:00am
formbricks-com 猬滐笍 Ignored (Inspect) Visit Preview Jan 17, 2024 11:00am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2024 •
edited

Thank you for following the naming conventions for pull request titles! 馃檹

mattinannt
mattinannt approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thank you for the fix :-) 馃敟 Worked great in my tests 馃挭

@mattinannt mattinannt added this pull request to the merge queue Jan 17, 2024
@mattinannt mattinannt removed this pull request from the merge queue due to a manual request Jan 17, 2024
@mattinannt mattinannt added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit e30f16c Jan 17, 2024
12 checks passed
@mattinannt mattinannt deleted the smiley-issue branch January 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dhruwang @mattinannt